nucleo000/snatchgame
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Resolve TypeScript compilation errors
Some checks failed
build-and-deploy / filter (push) Successful in 2s
Details
build-and-deploy / build (push) Failing after 8s
Details
build-and-deploy / deploy (push) Has been skipped
Details

Browse Source 
- Add explicit types for allPlayers array and forEach parameters
- Initialize Schema properties with default values
- Fix arithmetic operation types with null coalescing
- Resolve duplicate 'clients' property in object literal
This commit is contained in:
josedario87
2025-07-05 14:59:16 -06:00
parent c7fa9a12e7
commit 435f797750
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/app.config.ts
View File

@@ -65,7 +65,7 @@ export default config({
let totalPlayers = 0; let totalPlayers = 0;
let activeGames = 0; let activeGames = 0;
const gameRooms = []; const gameRooms = [];
const allPlayers = []; const allPlayers: any[] = [];
for (const room of rooms) { for (const room of rooms) {
if (room.name === 'game') { if (room.name === 'game') {
@@ -88,7 +88,7 @@ export default config({
// Extract player information with their tokens // Extract player information with their tokens
if (roomData.state && roomData.state.players) { if (roomData.state && roomData.state.players) {
// Use forEach to iterate over MapSchema properly // Use forEach to iterate over MapSchema properly
roomData.state.players.forEach((player, playerId) => { roomData.state.players.forEach((player: any, playerId: string) => {
// Skip internal MapSchema properties // Skip internal MapSchema properties
if (playerId.startsWith('$') || playerId === 'deletedItems') { if (playerId.startsWith('$') || playerId === 'deletedItems') {
return; return;

14
server/src/rooms/GameRoom.ts
View File

@@ -13,17 +13,17 @@ export class TokenInventory extends Schema {
} }
export class TradeOffer extends Schema { export class TradeOffer extends Schema {
@type("string") id: string; @type("string") id: string = "";
@type("string") offererId: string; @type("string") offererId: string = "";
@type("string") targetId: string; @type("string") targetId: string = "";
@type(TokenInventory) offering = new TokenInventory(); @type(TokenInventory) offering = new TokenInventory();
@type(TokenInventory) requesting = new TokenInventory(); @type(TokenInventory) requesting = new TokenInventory();
@type("string") status: string = "pending"; // "pending" | "accepted" | "rejected" | "snatched" | "cancelled" @type("string") status: string = "pending"; // "pending" | "accepted" | "rejected" | "snatched" | "cancelled"
} }
export class Player extends Schema { export class Player extends Schema {
@type("string") id: string; @type("string") id: string = "";
@type("string") name: string; @type("string") name: string = "";
@type("string") producerRole: string = "turkey"; // "turkey" | "coffee" | "corn" @type("string") producerRole: string = "turkey"; // "turkey" | "coffee" | "corn"
@type(TokenInventory) tokens = new TokenInventory(); @type(TokenInventory) tokens = new TokenInventory();
@type("number") points: number = 0; @type("number") points: number = 0;
@@ -101,7 +101,7 @@ export class GameRoom extends Room<GameState> {
} }
private calculatePoints(player: Player): number { private calculatePoints(player: Player): number {
const ownTokens = player.tokens[player.producerRole as keyof TokenInventory]; const ownTokens = player.tokens[player.producerRole as keyof TokenInventory] || 0;
const otherTokens = (player.tokens.turkey + player.tokens.coffee + player.tokens.corn) - ownTokens; const otherTokens = (player.tokens.turkey + player.tokens.coffee + player.tokens.corn) - ownTokens;
return ownTokens * 1 + otherTokens * 2; return ownTokens * 1 + otherTokens * 2;
} }
@@ -284,7 +284,7 @@ export class GameRoom extends Room<GameState> {
return { return {
roomId: this.roomId, roomId: this.roomId,
name: 'game', name: 'game',
clients: clients.length, clientCount: clients.length,
maxClients: this.maxClients, maxClients: this.maxClients,
locked: this.locked, locked: this.locked,
state: this.state, state: this.state,